[webkit-reviews] review granted: [Bug 200277] AX: com.apple.WebKit.WebContent at com.apple.WebKit: -[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames] : [Attachment 375166] patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 200277: AX: com.apple.WebKit.WebContent at com.apple.WebKit:
-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]
https://bugs.webkit.org/show_bug.cgi?id=200277

Attachment 375166: patch

https://bugs.webkit.org/attachment.cgi?id=375166&action=review




--- Comment #3 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 375166
  --> https://bugs.webkit.org/attachment.cgi?id=375166
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375166&action=review

R=me.

> Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:102
> +	   if (auto corePage = m_page->corePage()) {

I think there always is a core page unless we're in the destructor of WebPage,
so this check is possibly not needed.