[webkit-reviews] review granted: [Bug 200230] Web Inspector: Second call to setAttributeNS creates non-prefixed attribute : [Attachment 375184] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 200230: Web Inspector: Second call to setAttributeNS creates non-prefixed
attribute
https://bugs.webkit.org/show_bug.cgi?id=200230

Attachment 375184: Patch

https://bugs.webkit.org/attachment.cgi?id=375184&action=review




--- Comment #13 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 375184
  --> https://bugs.webkit.org/attachment.cgi?id=375184
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375184&action=review

r=me

> LayoutTests/inspector/dom/attributeModified-expected.txt:9
> +Creating test node...
> +{
> +  "id": "with-namespace"
> +}

We should also have a test that nodes initially start with attributes that
appropriately contain namespaces. Either here or in a different test.

> LayoutTests/inspector/dom/attributeModified.html:9
> +    node.id = id;

Here you could have a node that starts with a namespace attribute (including
one that you don't modify):

    node.setAttributeNS("http://example.com", "ex:test-name", "test-value");

> LayoutTests/inspector/dom/attributeModified.html:74
> +    <p>Tests for the DOM.attributeModified event.</p>

I think normally we just drop this leading whitespace but I could be wrong.