[webkit-reviews] review granted: [Bug 200282] [WHLSL] Checker sets wrong type for property access instruction with an ander : [Attachment 375183] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 15:13:21 PDT 2019


Myles C. Maxfield <mmaxfield at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 200282: [WHLSL] Checker sets wrong type for property access instruction
with an ander
https://bugs.webkit.org/show_bug.cgi?id=200282

Attachment 375183: patch

https://bugs.webkit.org/attachment.cgi?id=375183&action=review




--- Comment #5 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 375183
  --> https://bugs.webkit.org/attachment.cgi?id=375183
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375183&action=review

> LayoutTests/webgpu/whlsl/device-proper-type-checker.html:23
> +compute void computeShader(device Point[] buffer : register(u0), float3
threadID : SV_DispatchThreadID) {
> +    float x = buffer[0].x;
> +    float y = buffer[0].y;
> +    x += 1.0;
> +    y += 1.0;
> +    buffer[0].x = x;
> +    buffer[0].y = y;
> +}

Can't we use the fancy harness for this?


More information about the webkit-reviews mailing list