[webkit-reviews] review granted: [Bug 200270] [FTW] Refactor Direct2D code to follow Cairo's model to support modern WebKit : [Attachment 375171] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 13:27:31 PDT 2019


Dean Jackson <dino at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 200270: [FTW] Refactor Direct2D code to follow Cairo's model to support
modern WebKit
https://bugs.webkit.org/show_bug.cgi?id=200270

Attachment 375171: Patch

https://bugs.webkit.org/attachment.cgi?id=375171&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 375171
  --> https://bugs.webkit.org/attachment.cgi?id=375171
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375171&action=review

rs=me assuming you don't land those settings changes.

> Source/WebCore/page/Settings.yaml:148
> -  initial: false
> +  initial: true
>    onChange: setNeedsRecalcStyleInAllFrames
>  showRepaintCounter:
> -  initial: false
> +  initial: true
>    onChange: setNeedsRecalcStyleInAllFrames
>  visibleDebugOverlayRegions:
>    type: DebugOverlayRegions
>    initial: 0
>  showTiledScrollingIndicator:
> -  initial: false
> +  initial: true

I really think you don't want this!!


More information about the webkit-reviews mailing list