[webkit-reviews] review granted: [Bug 200162] [SOUP] Switch to use libsoup WebSockets API : [Attachment 374961] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 11:01:05 PDT 2019

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 200162: [SOUP] Switch to use libsoup WebSockets API

Attachment 374961: Patch


--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 374961
  --> https://bugs.webkit.org/attachment.cgi?id=374961

Me too, so much so that I forgot I had not already given r+....

Just one thing: the end goal should be to remove SocketStreamHandleImpl
altogether for platforms with platform-native sockets, not leave it with
RELEASE_ASSERTs. This means that we might need to eventually introduce a new
build flag, something like #if USE(PLATFORM_WEBSOCKETS) that will be equivalent
to #if HAVE(NSURLSESSION_WEBSOCKET) || USE(SOUP). But that can be future.

More information about the webkit-reviews mailing list