[webkit-reviews] review granted: [Bug 98934] [GTK] Datalist element support for TextFieldInputType : [Attachment 375156] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 98934: [GTK] Datalist element support for TextFieldInputType
https://bugs.webkit.org/show_bug.cgi?id=98934

Attachment 375156: Patch

https://bugs.webkit.org/attachment.cgi?id=375156&action=review




--- Comment #25 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 375156
  --> https://bugs.webkit.org/attachment.cgi?id=375156
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375156&action=review

> Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:51
> +    g_signal_connect(treeView, "row-activated",
G_CALLBACK(treeViewRowActivatedCallback), this);

I'm nervous about this one. I see it isn't disconnected in the destructor.
Surely it should use g_signal_connect_object()? Even if you always expect it to
be disconnected in the callback, better safe than sorry?