[webkit-reviews] review granted: [Bug 200249] Fix non-thread safe use of WeakPtr under sendSecItemRequest() : [Attachment 375113] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 29 16:23:19 PDT 2019

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 200249: Fix non-thread safe use of WeakPtr under sendSecItemRequest()

Attachment 375113: Patch


--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 375113
  --> https://bugs.webkit.org/attachment.cgi?id=375113

View in context: https://bugs.webkit.org/attachment.cgi?id=375113&action=review

> Source/WebKit/Shared/mac/SecItemShim.cpp:89
> +	  
temShimProxy::SecItemRequest(SecItemRequestData(requestType, query,
attributesToMatch)), 0, workQueue(), [&](auto reply) {

As long as we're trying this, let's use sendWithAsyncReply. I tried using a
synchronous message in https://bugs.webkit.org/show_bug.cgi?id=197747 but it
didn't work. This is a better approach, though.

More information about the webkit-reviews mailing list