[webkit-reviews] review granted: [Bug 200239] Contextual menu does not present when holding an embedded photo but works with link and attachments : [Attachment 375096] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 29 13:56:42 PDT 2019


Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 200239: Contextual menu does not present when holding an embedded photo but
works with link and attachments
https://bugs.webkit.org/show_bug.cgi?id=200239

Attachment 375096: Patch

https://bugs.webkit.org/attachment.cgi?id=375096&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 375096
  --> https://bugs.webkit.org/attachment.cgi?id=375096
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375096&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7971
> +	       UIContextMenuActionProvider actionMenuProvider = [weakSelf =
weakSelf, elementInfo = elementInfo] (NSArray<UIMenuElement *> *) -> UIMenu * {

why the [a = a, b = b]? can't you just [a, b]?


More information about the webkit-reviews mailing list