[webkit-reviews] review granted: [Bug 200189] Try fixing crash at com.apple.WebKit.Networking: NetworkProcess::setSharedHTTPCookieStorage : [Attachment 375093] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 200189: Try fixing crash at com.apple.WebKit.Networking:
NetworkProcess::setSharedHTTPCookieStorage
https://bugs.webkit.org/show_bug.cgi?id=200189

Attachment 375093: Patch

https://bugs.webkit.org/attachment.cgi?id=375093&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 375093
  --> https://bugs.webkit.org/attachment.cgi?id=375093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375093&action=review

r=me

> Source/WebKit/UIProcess/WebProcessPool.cpp:476
> +    if (!RunLoop::isMain()) {

We may want to put in a comment explaining this is a temporary workaround for
apps using our API on non-main threads.