[webkit-reviews] review granted: [Bug 200196] [JSC] Increment bytecode age only when SlotVisitor is first-visit : [Attachment 375067] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 29 12:58:06 PDT 2019

Robin Morisset <rmorisset at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 200196: [JSC] Increment bytecode age only when SlotVisitor is first-visit

Attachment 375067: Patch


--- Comment #5 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 375067
  --> https://bugs.webkit.org/attachment.cgi?id=375067

View in context: https://bugs.webkit.org/attachment.cgi?id=375067&action=review


> Source/JavaScriptCore/runtime/Options.h:201
> +    v(bool, countParseTimes, false, Normal, "counts prase times") \

prase => parse

> JSTests/stress/reparsing-unlinked-codeblock.js:27
> +shouldBe(second >= 3, true); // `hello`, `inner`, `world`. Another functions
can be destroyed, so using >= here.

Another => Other

More information about the webkit-reviews mailing list