[webkit-reviews] review granted: [Bug 200200] [WebGPU] Replace Vectors with HashSets for tracking resources used by GPUCommandBuffer : [Attachment 375039] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 200200: [WebGPU] Replace Vectors with HashSets for tracking resources used
by GPUCommandBuffer
https://bugs.webkit.org/show_bug.cgi?id=200200

Attachment 375039: Patch

https://bugs.webkit.org/attachment.cgi?id=375039&action=review




--- Comment #4 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 375039
  --> https://bugs.webkit.org/attachment.cgi?id=375039
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375039&action=review

> Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp:-347
> -    auto addResult = m_unnamedTypeMapping.add(&unnamedType, &*iterator);

How did this ever compile? I thought unused variables produced errors

> Source/WebCore/platform/graphics/gpu/GPUCommandBuffer.h:103
> +    void useBuffer(Ref<GPUBuffer>&& buffer) {
m_usedBuffers.addVoid(WTFMove(buffer)); }
> +    void useTexture(Ref<GPUTexture>&& texture) {
m_usedTextures.addVoid(WTFMove(texture)); }

I see a lot of production, but no consumption. Do the functions that we're
using for consumption just happen to be named the same between Vectors and
HashSets?