[webkit-reviews] review granted: [Bug 200034] StringBuilder::append(makeString(...)) is inefficient : [Attachment 375044] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 200034: StringBuilder::append(makeString(...)) is inefficient
https://bugs.webkit.org/show_bug.cgi?id=200034

Attachment 375044: Patch

https://bugs.webkit.org/attachment.cgi?id=375044&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 375044
  --> https://bugs.webkit.org/attachment.cgi?id=375044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375044&action=review

Nice

> Source/WebCore/ChangeLog:14
> +	   A lot more can be done to improve the efficiency of StringBuilder
use in the WHLSL code including:

Good tips. I might look into doing some of these. Metal codegen is one of the
most expensive phases in WHLSL codegen.