[webkit-reviews] review granted: [Bug 200027] Reorganize UIScriptController into platform-specific subclasses : [Attachment 375034] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 28 13:25:07 PDT 2019
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 200027: Reorganize UIScriptController into platform-specific subclasses
https://bugs.webkit.org/show_bug.cgi?id=200027
Attachment 375034: Patch
https://bugs.webkit.org/attachment.cgi?id=375034&action=review
--- Comment #28 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 375034
--> https://bugs.webkit.org/attachment.cgi?id=375034
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=375034&action=review
> Tools/ChangeLog:8
> + Instead of a mishmosh of #ifdefs and extraneous empty functions,
mishmash? pishposh? oshkosh?
> LayoutTests/swipe/resources/swipe-test.js:68
> + // FIXME: This test should probably not log playEventStream if it
doesn't.
doesn't what?
More information about the webkit-reviews
mailing list