[webkit-reviews] review denied: [Bug 198583] MediaSource.isTypeSupported claims FLAC-in-MP4 support on iOS and macOS, but plays silence : [Attachment 374641] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 27 18:47:18 PDT 2019


Maciej Stachowiak <mjs at apple.com> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 198583: MediaSource.isTypeSupported claims FLAC-in-MP4 support on iOS and
macOS, but plays silence
https://bugs.webkit.org/show_bug.cgi?id=198583

Attachment 374641: Patch

https://bugs.webkit.org/attachment.cgi?id=374641&action=review




--- Comment #9 from Maciej Stachowiak <mjs at apple.com> ---
Comment on attachment 374641
  --> https://bugs.webkit.org/attachment.cgi?id=374641
Patch

This broke the build on iOS, so r- for that (but otherwise looks fine as far as
I know).

/Volumes/Data/worker/iOS-12-Build-EWS/build/Source/WebCore/platform/graphics/av
foundation/objc/AVStreamDataParserMIMETypeCache.mm:43:12: error: cannot define
category for undefined class 'AVStreamDataParser'
@interface AVStreamDataParser (AVStreamDataParserExtendedMIMETypePrivate)
	   ^
In file included from
/Volumes/Data/worker/iOS-12-Build-EWS/build/Source/WebCore/platform/graphics/av
foundation/objc/AVStreamDataParserMIMETypeCache.mm:34:
PAL/pal/cocoa/AVFoundationSoftLink.h:70:33: note: forward declaration of class
here
SOFT_LINK_CLASS_FOR_HEADER(PAL, AVStreamDataParser)
				^
/Volumes/Data/worker/iOS-12-Build-EWS/build/Source/WebCore/platform/graphics/av
foundation/objc/AVStreamDataParserMIMETypeCache.mm:83:64: error: undeclared
selector 'canParseExtendedMIMEType:' [-Werror,-Wundeclared-selector]
    if ([PAL::getAVStreamDataParserClass()
respondsToSelector:@selector(canParseExtendedMIMEType:)])
							       ^
/Volumes/Data/worker/iOS-12-Build-EWS/build/Source/WebCore/platform/graphics/av
foundation/objc/AVStreamDataParserMIMETypeCache.mm:84:51: error: class method
'+canParseExtendedMIMEType:' not found (return type defaults to 'id')
[-Werror,-Wobjc-method-access]
	return [PAL::getAVStreamDataParserClass()
canParseExtendedMIMEType:mimeType];
						  ^~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.


More information about the webkit-reviews mailing list