[webkit-reviews] review denied: [Bug 200184] Add a missing null check to ShareableBitmap::makeCGImageCopy() : [Attachment 375004] Patch for landing
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 26 17:32:24 PDT 2019
Simon Fraser (smfr) <simon.fraser at apple.com> has denied review:
Bug 200184: Add a missing null check to ShareableBitmap::makeCGImageCopy()
https://bugs.webkit.org/show_bug.cgi?id=200184
Attachment 375004: Patch for landing
https://bugs.webkit.org/attachment.cgi?id=375004&action=review
--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 375004
--> https://bugs.webkit.org/attachment.cgi?id=375004
Patch for landing
I think you should make ShareableBitmap::createGraphicsContext() return nullptr
and fix the ~10 call sites that we care about.
More information about the webkit-reviews
mailing list