[webkit-reviews] review granted: [Bug 200149] Add crash diagnostics for debugging unexpected zapped cells. : [Attachment 374997] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 26 16:39:46 PDT 2019

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 200149: Add crash diagnostics for debugging unexpected zapped cells.

Attachment 374997: proposed patch.


--- Comment #11 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 374997
  --> https://bugs.webkit.org/attachment.cgi?id=374997
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=374997&action=review

r=me with a nit.

> Source/JavaScriptCore/heap/SlotVisitor.cpp:834
> +    m_heap.objectSpace().forEachBlock([&] (MarkedBlock::Handle* block) {

This is potentially dangerous because m_blocks can be added by the main thread
while the concurrent marker is working.
But maybe, it does not matter much since the crash trace itself offers much
more profitable information already.
Can you add a comment about it with FIXME or invent something safer?

More information about the webkit-reviews mailing list