[webkit-reviews] review granted: [Bug 200149] Add crash diagnostics for debugging unexpected zapped cells. : [Attachment 374944] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 26 11:46:50 PDT 2019


Michael Saboff <msaboff at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 200149: Add crash diagnostics for debugging unexpected zapped cells.
https://bugs.webkit.org/show_bug.cgi?id=200149

Attachment 374944: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=374944&action=review




--- Comment #5 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 374944
  --> https://bugs.webkit.org/attachment.cgi?id=374944
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=374944&action=review

r=me with some nits

> Source/JavaScriptCore/ChangeLog:10
> +	   SlotVisitor::visitChildren().  If a zapped cell is detected, we
we'll crash with

grammar *we well*.  May *we will* or *we'll*.

> Source/JavaScriptCore/heap/HeapCell.h:51
> +    // the rest of the cell header bits in tact for crash analysis uses.

*intact*


More information about the webkit-reviews mailing list