[webkit-reviews] review granted: [Bug 200122] AX: web process should load correct bundle path for MACCATALYST : [Attachment 374925] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 26 09:49:07 PDT 2019


Brent Fulgham <bfulgham at webkit.org> has granted Eric Liang
<ericliang at apple.com>'s request for review:
Bug 200122: AX: web process should load correct bundle path for MACCATALYST
https://bugs.webkit.org/show_bug.cgi?id=200122

Attachment 374925: Patch

https://bugs.webkit.org/attachment.cgi?id=374925&action=review




--- Comment #14 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 374925
  --> https://bugs.webkit.org/attachment.cgi?id=374925
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374925&action=review

r=me based on Chris's review of the Accessibility bundle change, and I approve
the preference read change.

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:484
> +	   "com.apple.Accessibility"

Yes -- this is fine. It's a preference read, not an XPC service connection as I
mistakenly asserted in an early comment.


More information about the webkit-reviews mailing list