[webkit-reviews] review granted: [Bug 200148] [JSC] Use unalignedLoad for JSRopeString fiber accesses : [Attachment 374934] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 200148: [JSC] Use unalignedLoad for JSRopeString fiber accesses
https://bugs.webkit.org/show_bug.cgi?id=200148

Attachment 374934: Patch

https://bugs.webkit.org/attachment.cgi?id=374934&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 374934
  --> https://bugs.webkit.org/attachment.cgi?id=374934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374934&action=review

r=me

> Source/JavaScriptCore/heap/MarkedBlock.h:305
> +    // Some of JSCell types assume that the last JSCell in a MarkedBlock has
a subsequent memory region (Footer) that can still safely accesible.

/accesible/accessed/

> Source/JavaScriptCore/heap/MarkedBlock.h:306
> +    // For example, JSRopeString assumes that it can safely access some
subsquent bytes of JSRopeString cell.

I suggest rephrasing "some subsquent bytes of JSRopeString cell" as "up to 2
bytes beyond the JSRopeString cell".