[webkit-reviews] review granted: [Bug 200139] [JSC] Ensure PackedCellPtr only takes non-large-allocation pointers : [Attachment 374915] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 200139: [JSC] Ensure PackedCellPtr only takes non-large-allocation pointers
https://bugs.webkit.org/show_bug.cgi?id=200139

Attachment 374915: Patch

https://bugs.webkit.org/attachment.cgi?id=374915&action=review




--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 374915
  --> https://bugs.webkit.org/attachment.cgi?id=374915
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374915&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +	   But this fact only meets when the JSCell is not large allocation.
Currently, we are using PackedCellPtr

still not fixed: /meet/holds/

> Source/JavaScriptCore/ChangeLog:10
> +	   only for the cell types which holds the above requirement. But we
would like to ensure that statically.

this one should be 'meet' instead of 'holds'.