[webkit-reviews] review granted: [Bug 200108] WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest : [Attachment 374903] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Jiewen Tan <jiewen_tan at apple.com>'s
request for review:
Bug 200108: WebPageProxy::receivedPolicyDecision should check navigation ID
before clear pendingAPIRequest
https://bugs.webkit.org/show_bug.cgi?id=200108

Attachment 374903: Patch

https://bugs.webkit.org/attachment.cgi?id=374903&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 374903
  --> https://bugs.webkit.org/attachment.cgi?id=374903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374903&action=review

r=me

> Source/WebKit/UIProcess/PageLoadState.cpp:242
> +const PageLoadState::PendingAPIRequest& PageLoadState::pendingAPIRequest()
const

FYI, you could also write:
auto PageLoadState::pendingAPIRequest() const -> const PendingAPIRequest&

This avoid the extra PageLoadState::.

> Source/WebKit/UIProcess/WebPageProxy.cpp:4625
> +	   m_pageLoadState.clearPendingAPIRequest(transaction);

Any reason does not check the navigation ID before clearing instead of checking
the URL? Checking the URL does not seem reliable.