[webkit-reviews] review granted: [Bug 199984] Legacy numeric literals should not permit separators or BigInt : [Attachment 374564] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 199984: Legacy numeric literals should not permit separators or BigInt
https://bugs.webkit.org/show_bug.cgi?id=199984

Attachment 374564: Patch

https://bugs.webkit.org/attachment.cgi?id=374564&action=review




--- Comment #5 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 374564
  --> https://bugs.webkit.org/attachment.cgi?id=374564
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374564&action=review

r=me.

> Source/JavaScriptCore/parser/Lexer.cpp:1628
> +    bool isLegacyLiteral = m_buffer8.size();

For clarity can you add:

ASSERT(!m_buffer8.size() || (m_buffer8.size() == 1 && m_buffer[0] == '0'));