[webkit-reviews] review granted: [Bug 200105] [iOS WK2] A top fixed bar can flicker when scrolling with the keyboard up : [Attachment 374849] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 24 19:55:56 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 200105: [iOS WK2] A top fixed bar can flicker when scrolling with the
keyboard up
https://bugs.webkit.org/show_bug.cgi?id=200105

Attachment 374849: Patch

https://bugs.webkit.org/attachment.cgi?id=374849&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 374849
  --> https://bugs.webkit.org/attachment.cgi?id=374849
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374849&action=review

> LayoutTests/scrollingcoordinator/ios/fixed-scrolling-with-keyboard.html:32
> +	   function getScrollingTreeUIScript()
> +	   {
> +	       return `(function() {
> +		   return uiController.scrollingTreeAsText;
> +	       })();`;
> +	   }

Nit - maybe we should wrap this in a UIHelper method as well?


More information about the webkit-reviews mailing list