[webkit-reviews] review granted: [Bug 174313] Implement EventTarget constructor : [Attachment 374820] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 24 18:39:10 PDT 2019
Darin Adler <darin at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 174313: Implement EventTarget constructor
https://bugs.webkit.org/show_bug.cgi?id=174313
Attachment 374820: Patch
https://bugs.webkit.org/attachment.cgi?id=374820&action=review
--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 374820
--> https://bugs.webkit.org/attachment.cgi?id=374820
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=374820&action=review
I like most everything about the patch except for the class name. Could we call
it EventTargetConstructible or EventTargetConcrete or something that is more
specific than "Impl"?
> Source/WebCore/dom/EventTargetImpl.cpp:30
> +#include <wtf/IsoMallocInlines.h>
Don’t need this since it’s also in the header.
> Source/WebCore/dom/EventTargetImpl.h:41
> + ~EventTargetImpl() = default;
Why is this needed? Won’t this compile fine without this and work properly?
> Source/WebCore/dom/EventTargetImpl.h:45
> + using RefCounted::deref;
> +private:
Normally we’d leave a blank line before "private".
> Source/WebCore/dom/EventTargetImpl.h:46
> + EventTargetImpl(ScriptExecutionContext&);
Should have "explicit" here.
More information about the webkit-reviews
mailing list