[webkit-reviews] review granted: [Bug 200103] [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA : [Attachment 374841] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 24 18:26:30 PDT 2019


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 200103: [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not
allocating too large VA
https://bugs.webkit.org/show_bug.cgi?id=200103

Attachment 374841: Patch

https://bugs.webkit.org/attachment.cgi?id=374841&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 374841
  --> https://bugs.webkit.org/attachment.cgi?id=374841
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374841&action=review

r=me

> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:-46
> -		0C2DA1481F3BEB4900DBC317 /* MachVMSPI.h in Headers */ = {isa =
PBXBuildFile; fileRef = 0C2DA12C1F3BEB4900DBC317 /* MachVMSPI.h */; };

I don't see the old MachVMSPI.h being deleted.	Are you missing a "svn rm"?


More information about the webkit-reviews mailing list