[webkit-reviews] review granted: [Bug 199326] Allow Clients to Add Fields to the AutoFillContext Dictionary : [Attachment 374812] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 24 16:35:29 PDT 2019
Wenson Hsieh <wenson_hsieh at apple.com> has granted Priyanka
<pagarwal999 at apple.com>'s request for review:
Bug 199326: Allow Clients to Add Fields to the AutoFillContext Dictionary
https://bugs.webkit.org/show_bug.cgi?id=199326
Attachment 374812: Patch
https://bugs.webkit.org/attachment.cgi?id=374812&action=review
--- Comment #20 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 374812
--> https://bugs.webkit.org/attachment.cgi?id=374812
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=374812&action=review
This patch looks great. Thanks again for working on the test! Just a couple
more very minor nits.
> Tools/ChangeLog:4
> +
Nit - extra newline here.
> Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:532
> + NSDictionary *expected = @{ @"strongPasswordAdditionalContext" :
@"testUUID" };
Nit - extra space here between = and @
More information about the webkit-reviews
mailing list