[webkit-reviews] review granted: [Bug 199326] Allow Clients to Add Fields to the AutoFillContext Dictionary : [Attachment 374800] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 24 14:00:50 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> has granted Priyanka
<pagarwal999 at apple.com>'s request for review:
Bug 199326: Allow Clients to Add Fields to the AutoFillContext Dictionary
https://bugs.webkit.org/show_bug.cgi?id=199326

Attachment 374800: Patch

https://bugs.webkit.org/attachment.cgi?id=374800&action=review




--- Comment #15 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 374800
  --> https://bugs.webkit.org/attachment.cgi?id=374800
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374800&action=review

r=mews! (with the NSLog removed)

> Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:553
> +    NSLog( @"%@", [[webView textInputContentView] _autofillContext] );

Nit — it looks like you left a bit of logging here.


More information about the webkit-reviews mailing list