[webkit-reviews] review denied: [Bug 200083] REGRESSION (r244995): Assertion failure when addEventListener to an SVGElement which has an. instance in shadow tree : [Attachment 374787] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 200083: REGRESSION (r244995): Assertion failure when addEventListener to an
SVGElement which has an. instance in shadow tree
https://bugs.webkit.org/show_bug.cgi?id=200083

Attachment 374787: Patch

https://bugs.webkit.org/attachment.cgi?id=374787&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 374787
  --> https://bugs.webkit.org/attachment.cgi?id=374787
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374787&action=review

> Source/WebCore/bindings/js/JSLazyEventListener.cpp:89
> +	   ASSERT(m_originalNode.get() == &node ||
!m_originalNode->isInShadowTree() && node.isInShadowTree());

This assertion isn’t quite right. We need to restrict it to the shadow tree of
SVG use element instead.