[webkit-reviews] review granted: [Bug 199489] run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api : [Attachment 374738] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 199489: run-javascriptcore-tests won't report test results for testmasm,
testair, testb3, testdfg and test api
https://bugs.webkit.org/show_bug.cgi?id=199489

Attachment 374738: Patch

https://bugs.webkit.org/attachment.cgi?id=374738&action=review




--- Comment #71 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 374738
  --> https://bugs.webkit.org/attachment.cgi?id=374738
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374738&action=review

lgtm

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:335
> +	   # Currently run-javascriptcore-test doesn't support run javascript
core test binaries list below remotely

This looks weird/incomplete. Maybe rephrase something like:

# Currently run-javascriptcore-test doesn't support remotely running few
javascript core test binaries.