[webkit-reviews] review granted: [Bug 200055] ImageDecoderDirect2D::hotSpot() should return WTF::nullopt instead of default constructed value : [Attachment 374726] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 23 16:47:58 PDT 2019


Brent Fulgham <bfulgham at webkit.org> has granted Konstantin Tokarev
<annulen at yandex.ru>'s request for review:
Bug 200055: ImageDecoderDirect2D::hotSpot() should return WTF::nullopt instead
of default constructed value
https://bugs.webkit.org/show_bug.cgi?id=200055

Attachment 374726: Patch

https://bugs.webkit.org/attachment.cgi?id=374726&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 374726
  --> https://bugs.webkit.org/attachment.cgi?id=374726
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374726&action=review

r=me

> Source/WebCore/platform/graphics/win/ImageDecoderDirect2D.cpp:128
> +    return WTF::nullopt;

Doh! Good catch.


More information about the webkit-reviews mailing list