[webkit-reviews] review granted: [Bug 199341] Web Inspector: Styles: Command-X should cut selected properties : [Attachment 374710] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 199341: Web Inspector: Styles: Command-X should cut selected properties
https://bugs.webkit.org/show_bug.cgi?id=199341

Attachment 374710: Patch

https://bugs.webkit.org/attachment.cgi?id=374710&action=review




--- Comment #17 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 374710
  --> https://bugs.webkit.org/attachment.cgi?id=374710
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374710&action=review

r=me, nice work!  :)

> Source/WebInspectorUI/ChangeLog:22
> +	   Introduce this method to use when copying and cutting CSS
properties.

This kind of ChangeLog message doesn't really add anything useful.  I'd either
explain _what_ happens inside `_copySelectedProperties` or remove it.

> Source/WebInspectorUI/ChangeLog:25
> +	   Introduce this method to use when cutting and removing CSS
properties (by pressing Delete).

Ditto (>22).