[webkit-reviews] review granted: [Bug 200018] Sometimes we miss removable CheckInBounds : [Attachment 374652] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 22 16:47:51 PDT 2019

Saam Barati <sbarati at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 200018: Sometimes we miss removable CheckInBounds

Attachment 374652: Patch


--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 374652
  --> https://bugs.webkit.org/attachment.cgi?id=374652

View in context: https://bugs.webkit.org/attachment.cgi?id=374652&action=review


> Source/JavaScriptCore/ChangeLog:8
> +	   We failed to remove the CheckInBounds bounds because we did not see
that the index was nonnegative. This is because we do not see the relationship
between the two
> +	   separate zero constants that appear in the IR for the given test
case. This patch re-adds the hack to de-duplicate m_zero that was removed in 
> +	   <https://trac.webkit.org/changeset/241228/webkit>.

nit: should go below "Reviewed by ..."

Might be worth also opening a bug on not being reliant on the exact node
pointer. Or at least understanding why it's ok to rely on the actual node
pointer value.

More information about the webkit-reviews mailing list