[webkit-reviews] review granted: [Bug 199988] AX: CrashTracer: com.apple.WebKit.WebContent at WebKit: WebKit::WebSpeechSynthesisClient::speak : [Attachment 374634] patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 199988: AX: CrashTracer: com.apple.WebKit.WebContent at WebKit:
WebKit::WebSpeechSynthesisClient::speak
https://bugs.webkit.org/show_bug.cgi?id=199988

Attachment 374634: patch

https://bugs.webkit.org/attachment.cgi?id=374634&action=review




--- Comment #9 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 374634
  --> https://bugs.webkit.org/attachment.cgi?id=374634
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374634&action=review

R=me.

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:261
> +    speechSynthesisData().speakingStartedCompletionHandler();

Do we need to guard against the completion handler not being set?