[webkit-reviews] review granted: [Bug 200009] Correct web audio-related crash in seed reports : [Attachment 374622] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 200009: Correct web audio-related crash in seed reports
https://bugs.webkit.org/show_bug.cgi?id=200009

Attachment 374622: Patch

https://bugs.webkit.org/attachment.cgi?id=374622&action=review




--- Comment #4 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 374622
  --> https://bugs.webkit.org/attachment.cgi?id=374622
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374622&action=review

R=me.

>
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:380
> +    (global-name "com.apple.coremedia.audioprocessingtap.xpc") ;;
<rdar://problem/51565203>

I think the explicit allow in not needed, since it is already allowed in the
imported sandbox file.

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:609
> +	  (global-name "com.apple.coremedia.audioprocessingtap.xpc") ;;
<rdar://problem/51565203>

Is this needed on macOS?