[webkit-reviews] review granted: [Bug 199948] Make sure to unref captured lambda variables given to _strictTrustEvaluate in the main thread : [Attachment 374533] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 22 10:33:43 PDT 2019
Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 199948: Make sure to unref captured lambda variables given to
_strictTrustEvaluate in the main thread
https://bugs.webkit.org/show_bug.cgi?id=199948
Attachment 374533: Patch
https://bugs.webkit.org/attachment.cgi?id=374533&action=review
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 374533
--> https://bugs.webkit.org/attachment.cgi?id=374533
Patch
Sure. I think it would be a little more consistent with the rest of the code
to check the weak pointer in the lambda, then pass a NetworkSessionCocoa& to
processServerTrustEvaluation.
More information about the webkit-reviews
mailing list