[webkit-reviews] review granted: [Bug 199945] [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process. : [Attachment 374597] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Alberto Lopez
Perez <clopez at igalia.com>'s request for review:
Bug 199945: [webkitpy] Allow the testrunner driver to setup the environment
completely without needing to start the server process.
https://bugs.webkit.org/show_bug.cgi?id=199945

Attachment 374597: Patch

https://bugs.webkit.org/attachment.cgi?id=374597&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 374597
  --> https://bugs.webkit.org/attachment.cgi?id=374597
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374597&action=review

> Tools/Scripts/webkitpy/port/driver_unittest.py:396
> +		   self.assertNotEqual(environ_driver[var], None)
> +
> +
>      def test_create_temporal_home_dir(self):

All the other surrounding functions have only one line between them (though I
thought two was supposed to be standard for python).