[webkit-reviews] review granted: [Bug 199992] [ews-build] EWS fails to parse multi-line full_results.json : [Attachment 374576] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 21 14:20:54 PDT 2019

Alexey Proskuryakov <ap at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 199992: [ews-build] EWS fails to parse multi-line full_results.json

Attachment 374576: Patch


--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 374576
  --> https://bugs.webkit.org/attachment.cgi?id=374576

View in context: https://bugs.webkit.org/attachment.cgi?id=374576&action=review

> Tools/BuildSlaveSupport/ews-build/layout_test_failures.py:54
> +	   # Concatenate content into single line since Buildbot split lines
longer than 4096 characters

Nitpick: s/split/splits/, and there should be a period at the end.

Since the root cause of the problem is at JSON generation side, this should
probably have a link to a bug about fixing that, or a brief explanation of why
it's not possible, and why the workaround is permanent. After all, if we
produce something that we call "JSON", that should be valid JSON, not a broken

> Tools/BuildSlaveSupport/ews-build/layout_test_failures.py:56
> +	   content_string = ''.join(content_string.splitlines())

Is this better than .translate(None, '\r\n')?

More information about the webkit-reviews mailing list