[webkit-reviews] review granted: [Bug 199982] Speed up HashTable decoding by reserving capacity and avoiding rehashing : [Attachment 374560] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 199982: Speed up HashTable decoding by reserving capacity and avoiding
rehashing
https://bugs.webkit.org/show_bug.cgi?id=199982

Attachment 374560: Patch

https://bugs.webkit.org/attachment.cgi?id=374560&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 374560
  --> https://bugs.webkit.org/attachment.cgi?id=374560
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374560&action=review

> Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:1041
> +TEST(WTF_HashMap, ReserveInitialCapacity)

Can you also add a test where you add more things past the initial capacity and
ensure that the integrity of the table is maintained. Also, what happens when
you reserve initial capacity then remove an entry from the table? Will we
immediately rehash? (I’m not sure that’s terrible since that goes against the
spirit of the API, but I’m just curious).

Might be worth adding a test where we do deletion after reserveInitialCapacity
too just to ensure the integrity of the table