[webkit-reviews] review granted: [Bug 199718] [Text autosizing] Do not nuke the style on dynamicViewportSizeUpdate : [Attachment 374501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 19 15:43:16 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 199718: [Text autosizing] Do not nuke the style on
dynamicViewportSizeUpdate
https://bugs.webkit.org/show_bug.cgi?id=199718

Attachment 374501: Patch

https://bugs.webkit.org/attachment.cgi?id=374501&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 374501
  --> https://bugs.webkit.org/attachment.cgi?id=374501
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374501&action=review

> Source/WebCore/page/Page.cpp:3014
> +void Page::invalidateTextAutoSizeInAllFrames()

recomputeTextAutoSizingInAllFrames

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3362
> +    const Seconds defaultTextAutoSizingDelayOnViewportChange = 80_ms;
> +    auto textAutoSizingDelayOnViewportChange =
defaultTextAutoSizingDelayOnViewportChange;
> +    if (willBeVisuallyNonEmptySoon) {
> +	   // Be a bit more agressive on the first display.
> +	   const Seconds shortTextAutoSizingDelayOnViewportChange = 20_ms;
> +	   textAutoSizingDelayOnViewportChange =
shortTextAutoSizingDelayOnViewportChange;
> +    } else if (!isVisaullyNonEmpty) {
> +	   // We don't anticipate any paining after the next upcoming layout.
> +	   const Seconds longTextAutoSizingDelayOnViewportChange = 100_ms;
> +	   textAutoSizingDelayOnViewportChange =
longTextAutoSizingDelayOnViewportChange;
> +
> +    }

Maybe wrap in a lambda


More information about the webkit-reviews mailing list