[webkit-reviews] review granted: [Bug 199940] Add a menu item to toggle between showing and hiding link previews : [Attachment 374466] Patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 199940: Add a menu item to toggle between showing and hiding link previews
https://bugs.webkit.org/show_bug.cgi?id=199940

Attachment 374466: Patch

https://bugs.webkit.org/attachment.cgi?id=374466&action=review




--- Comment #5 from Beth Dakin <bdakin at apple.com> ---
Comment on attachment 374466
  --> https://bugs.webkit.org/attachment.cgi?id=374466
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374466&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7674
> +    if (!originalMenu)

Is there ever a case when a menu would no items would be represented by a nil
menu? I just want to make sure that if a client removes ALL of the menu items,
we still provide this one.