[webkit-reviews] review granted: [Bug 199934] [GStreamer] Flush get_range calls during PAUSED->READY in WebKitWebSource : [Attachment 374444] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 19 00:07:04 PDT 2019


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 199934: [GStreamer] Flush get_range calls during PAUSED->READY in
WebKitWebSource
https://bugs.webkit.org/show_bug.cgi?id=199934

Attachment 374444: Patch

https://bugs.webkit.org/attachment.cgi?id=374444&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 374444
  --> https://bugs.webkit.org/attachment.cgi?id=374444
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374444&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:780
> +	   {

This should go to the line above.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:785
> +	   locker.unlockEarly();

This shouldn't be needed.


More information about the webkit-reviews mailing list