[webkit-reviews] review granted: [Bug 199923] Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI : [Attachment 374425] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 199923: Add and test
_WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
https://bugs.webkit.org/show_bug.cgi?id=199923

Attachment 374425: Patch

https://bugs.webkit.org/attachment.cgi?id=374425&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 374425
  --> https://bugs.webkit.org/attachment.cgi?id=374425
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374425&action=review

> Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:106
> +    NSURL *tempDir = [NSURL fileURLWithPath:[NSTemporaryDirectory()
stringByAppendingPathComponent:@"CustomPathsTest"] isDirectory:YES];

Maybe add EXPECT_FALSE([fileManager fileExistsAtPath:[tempDir
URLByAppendingPathComponent:@"1"].path])

> Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:120
> +    webView.UIDelegate = delegate.get();

Shouldn't we load a page like [webView
loadTestPageNamed:@"enumerateMediaDevices"]?