[webkit-reviews] review granted: [Bug 199912] [iOS] Fast and complex text codepaths disagree about how to lay out bopomofo with tone marks : [Attachment 374402] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 199912: [iOS] Fast and complex text codepaths disagree about how to lay out
bopomofo with tone marks
https://bugs.webkit.org/show_bug.cgi?id=199912

Attachment 374402: Patch

https://bugs.webkit.org/attachment.cgi?id=374402&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 374402
  --> https://bugs.webkit.org/attachment.cgi?id=374402
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374402&action=review

> Source/WebCore/ChangeLog:10
> +	   This is because CoreText has special composition rules for CJK
languages, which we don't have in our simple
> +	   text codepath. Rather than implementing the composition rules in
WebKit, we can simply disable them in

Do we have them in our complex text codepath? Should we instead flip to that
codepath when necessary?