[webkit-reviews] review granted: [Bug 199905] REGRESSION: Panning on an Amazon product image scrolls the page on iPadOS : [Attachment 374382] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 18 11:55:33 PDT 2019


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 199905: REGRESSION: Panning on an Amazon product image scrolls the page on
iPadOS
https://bugs.webkit.org/show_bug.cgi?id=199905

Attachment 374382: Patch

https://bugs.webkit.org/attachment.cgi?id=374382&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 374382
  --> https://bugs.webkit.org/attachment.cgi?id=374382
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374382&action=review

> Source/WebCore/page/Quirks.cpp:283
> +    if (isAmazon() && is<Element>(target)) {

Do you need to check target is not null?


More information about the webkit-reviews mailing list