[webkit-reviews] review granted: [Bug 199886] [WHLSL] The lexer should not choke on a single '/' : [Attachment 374356] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 17 17:57:12 PDT 2019

Myles C. Maxfield <mmaxfield at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 199886: [WHLSL] The lexer should not choke on a single '/'

Attachment 374356: Patch


--- Comment #6 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 374356
  --> https://bugs.webkit.org/attachment.cgi?id=374356

View in context: https://bugs.webkit.org/attachment.cgi?id=374356&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp:124
> +	   if (dumpPassFailure)
> +	       dataLogLn("failed to parse the standard library: ",
> +	   return WTF::nullopt;
> +    }

See comment below.

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.cpp:81
> +	       return parseFailure;

The standard library should never be a parse failure. Instead of returning the
error, we should ASSERT(). The return type of this function should be "void".

More information about the webkit-reviews mailing list