[webkit-reviews] review requested: [Bug 199886] [WHLSL] The lexer should not choke on a single '/' : [Attachment 374354] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 17 17:15:43 PDT 2019


Robin Morisset <rmorisset at apple.com> has asked	for review:
Bug 199886: [WHLSL] The lexer should not choke on a single '/'
https://bugs.webkit.org/show_bug.cgi?id=199886

Attachment 374354: Patch

https://bugs.webkit.org/attachment.cgi?id=374354&action=review




--- Comment #4 from Robin Morisset <rmorisset at apple.com> ---
Created attachment 374354

  --> https://bugs.webkit.org/attachment.cgi?id=374354&action=review

Patch

Added a test, and modified parseFullStandardLibrary so we only load and
decompress the stdlib once, using the static NeverDestroyed<String> as
suggested by Myles.


More information about the webkit-reviews mailing list