[webkit-reviews] review granted: [Bug 199818] IndexedDB: error in starting version change transaction may be neglected : [Attachment 374250] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 199818: IndexedDB: error in starting version change transaction may be
neglected
https://bugs.webkit.org/show_bug.cgi?id=199818

Attachment 374250: Patch

https://bugs.webkit.org/attachment.cgi?id=374250&action=review




--- Comment #13 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 374250
  --> https://bugs.webkit.org/attachment.cgi?id=374250
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374250&action=review

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:655
> +    auto operation = WTFMove(m_currentOpenDBRequest);

If you make an `IDBResultData result` after 655...

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:661
> +	   operation->connection().didOpenDatabase(result);

This line and 666 are the same, can be moved out if we make a result variable
before the if

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:666
> +	   operation->connection().didOpenDatabase(result);

This line and 661 are the same, can be moved out if we make a result variable
before the if