[webkit-reviews] review granted: [Bug 199840] REGRESSION: fast/events/watchos/double-tap-to-zoom* tests crashing in com.apple.WebKit: -[WKContentView(WKInteraction) _singleTapDidReset:] : [Attachment 374254] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 199840: REGRESSION: fast/events/watchos/double-tap-to-zoom* tests crashing
in com.apple.WebKit: -[WKContentView(WKInteraction) _singleTapDidReset:]
https://bugs.webkit.org/show_bug.cgi?id=199840

Attachment 374254: Patch

https://bugs.webkit.org/attachment.cgi?id=374254&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 374254
  --> https://bugs.webkit.org/attachment.cgi?id=374254
Patch

Looks find to me. Is there a reason to prefer this over making
_lastActiveTouchIdentifier an ivar of type RetainPtr<NSNumber>, and then
exposing a getter that returns _lastActiveTouchIdentifier.get()? I think this
is how most of our ObjC properties in WebKit are implemented.