[webkit-reviews] review denied: [Bug 199832] [bmalloc] Add option to use pthread mutex instead of spin lock. : [Attachment 374222] PATCH

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has denied Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 199832: [bmalloc] Add option to use pthread mutex instead of spin lock.
https://bugs.webkit.org/show_bug.cgi?id=199832

Attachment 374222: PATCH

https://bugs.webkit.org/attachment.cgi?id=374222&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 374222
  --> https://bugs.webkit.org/attachment.cgi?id=374222
PATCH

If we are going to support this we should try to minimize the usage of #if
BUSE(PTHREAD_MUTEX). e.g. The constructor should exist everywhere but only do
things for pthreads, try_lock could be pthread_mutex_trylock, etc.