[webkit-reviews] review granted: [Bug 199814] Add release logging to AudioSampleDataSource : [Attachment 374174] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 199814: Add release logging to AudioSampleDataSource
https://bugs.webkit.org/show_bug.cgi?id=199814

Attachment 374174: Patch

https://bugs.webkit.org/attachment.cgi?id=374174&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 374174
  --> https://bugs.webkit.org/attachment.cgi?id=374174
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374174&action=review

> Source/WebCore/ChangeLog:16
> +	   In that case, we change of logger when changing of
MediaStreamTrackPrivate.

Nit: s/change of logger when changing of/change the logger when changing the/

> Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:278
> +	       ALWAYS_LOG("sample ", timeStamp, " is not completely in range
[", startFrame, " .. ", endFrame, "], returning ", framesAvailable, " frames");
> +	       if (framesAvailable < sampleCount)
> +		   ALWAYS_LOG("not enough data available, returning zeroes");

Nit: should these be ERROR_LOG?